Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove using namespace from header file #276

Merged
merged 8 commits into from
Jun 16, 2020
Merged

Remove using namespace from header file #276

merged 8 commits into from
Jun 16, 2020
+143 −143

Conversation

lawben
Copy link
Contributor

@lawben lawben commented Jun 4, 2020

As mentioned in #266, having a using namespace statement in a header file can cause ambiguous references down the line. This PR removes the using namespace FASTER::core statement from a header file and adapts the depending source files to use core:: explicitly.

@ghost
Copy link

ghost commented Jun 4, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@badrishc badrishc merged commit 039cc10 into microsoft:master Jun 16, 2020
@badrishc badrishc mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawben @badrishc